Skip to content

Conversation

@madhurgupta10
Copy link
Collaborator

Description
Added Forgot Password Unit Test for Login Activity in Kotlin

Fixes #2686 Write Unit Test for Login Activity

What changes did you make and why?
Added Unit Test for Forgot Password URL

Tests performed
Tested betaDebug on Xiaomi Mi A1 with API level 28.

Logs
Testing started at 06:36 PM ...

03/23 18:36:24: Launching isForgotPasswordWo...()
No apk changes detected since last installation, skipping installation of C:\Users\madhu\Desktop\apps-android-commons\app\build\outputs\apk\beta\debug\app-commons-v2.10.1-master-beta-debug.apk
No apk changes detected since last installation, skipping installation of C:\Users\madhu\Desktop\apps-android-commons\app\build\outputs\apk\androidTest\beta\debug\app-commons-v2.10.1-master-beta-debug-androidTest.apk
Running tests

$ adb shell am instrument -w -r -e debug false -e class 'fr.free.nrw.commons.LoginActivityTest#isForgotPasswordWorks' fr.free.nrw.commons.beta.test/androidx.test.runner.AndroidJUnitRunner
Connected to process 21700 on device xiaomi-mi_a1-7af99b9c0404

Started running tests
Tests ran to completion.

Test Passed

@codecov-io
Copy link

Codecov Report

Merging #2723 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2723   +/-   ##
======================================
  Coverage    2.71%   2.71%           
======================================
  Files         267     267           
  Lines       12838   12838           
  Branches     1141    1141           
======================================
  Hits          349     349           
  Misses      12463   12463           
  Partials       26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7302d4...b1bab0f. Read the comment docs.

Copy link
Contributor

@maskaravivek maskaravivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for forgot password exists in my other PR.

@madhurgupta10
Copy link
Collaborator Author

@maskaravivek Sorry didn't see that, Closing this PR since the test is already covered #2700

@madhurgupta10 madhurgupta10 deleted the unit-test-forgot branch March 27, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants